Skip to content

MQE-2126: Can't modify DataEntity data #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2020
Merged

MQE-2126: Can't modify DataEntity data #703

merged 5 commits into from
May 13, 2020

Conversation

okolesnyk
Copy link
Member

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented May 13, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 55.944% when pulling c1aa918 on MQE-2126 into 3510e9f on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 55.915% when pulling d0afb1c on MQE-2126 into 3510e9f on develop.

@soumyau soumyau self-requested a review May 13, 2020 18:41
soumyau
soumyau suggested changes May 13, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does devdoc need updates? magento2-functional-testing-framework/docs/data.md
Added minor comments + check failing functional test on travis.

dev/tests/functional/tests/MFTF/DevDocs/Test/DevDocsTest.xml Outdated
@@ -46,5 +46,6 @@
<argument name="test" value="{{HelperData.entityField}}" />
<argument name="entityTest" value="HelperData" />
</actionGroup>
<comment userInput="{{MessageData.numbers}}" stepKey="outputMergedArray" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Maybe add an assertContains step instead, to validate array merge?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. ✅

@soumyau soumyau requested a review from dobooth May 13, 2020 19:34
soumyau
soumyau approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@okolesnyk okolesnyk merged commit 545a266 into develop May 13, 2020
@tomreece tomreece deleted the MQE-2126 branch July 27, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyau soumyau soumyau approved these changes

@dobooth dobooth Awaiting requested review from dobooth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okolesnyk @coveralls @soumyau